[FEAT/#134] multipart 통신 구현 #147
Merged
+204
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roel4990
approved these changes
Jan 23, 2025
Comment on lines
9
to
10
| @SerialName("userId") val userId: Long, | ||
| @SerialName("title") val title: String, |
There was a problem hiding this comment.
Suggested change
| @SerialName("userId") val userId: Long, | |
| @SerialName("title") val title: String, | |
| @SerialName("userId") | |
| val userId: Long, | |
| @SerialName("title") | |
| val title: String, |
P5: 이런식으로 작성하는건 어떨까요?!
…-multipart # Conflicts: # app/src/main/java/com/spoony/spoony/data/service/PostService.kt
chattymin
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
p1) 패키지 위치가 앱잼이라 이상하네요~
추후 수정해주세요!! 토론 환영합니다
Comment on lines
+69
to
+74
| val requestBody = jsonString.toRequestBody("application/json".toMediaType()) | ||
|
|
||
| // 2. ContentUriRequestBody를 사용하여 이미지 변환 | ||
| val photoParts = photos.map { uri -> | ||
| ContentUriRequestBody(context, uri).toFormData("photos") | ||
| } |
| fun toFormData(name: String) = MultipartBody.Part.createFormData(name, getFileName(), this) | ||
|
|
||
| companion object { | ||
| const val IMAGE_SIZE_MB = 1 |
There was a problem hiding this comment.
p5) 추후 서버측과 논의 후 수정 부탁드려요~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️