CMake: SQLITE_OMIT_LOAD_EXTENSION not properly set

[brt-v]

I'm fairly new to this project, so apologies if I'm overlooking something.

The main CMakeList.txt offers a SQLITE_OMIT_LOAD_EXTENSION options and sets it for the SQLiteCpp project (here). However, it does not set it for [sqlite3](https://github.com/SRombauts/SQLiteCpp/tree/master/sqlite3)

So I think that in the sqlite3 CMakeLists.txt this should be added:

if (SQLITE_OMIT_LOAD_EXTENSION)
    target_compile_definitions(sqlite3 PUBLIC SQLITE_OMIT_LOAD_EXTENSION)
    message(STATUS "Compile sqlite3 with SQLITE_OMIT_LOAD_EXTENSION")
endif (SQLITE_OMIT_LOAD_EXTENSION)

Also, a related question: the sqlite documentation lists some Recommended Compile-time Options. Can (some of) these be set in conjunction with SQLiteCpp? What's the best way to do this with CMake?

Thanks!

[UnixY2K]

I think for the first you can submit a PR to get it merged, however you need to check if the found sqlite is the current bundled.

for the second option the same applies if using the bundled sqlite + having an option to change the value (default would be true)

[brt-v]

Thanks, I just submitted a PR.

however you need to check if the found sqlite is the current bundled.

the new option is only applied to the bundled sqlite3, so I don't think there's an issue for the case that it isn't bundled.

for the second option the same applies if using the bundled sqlite + having an option to change the value (default would be true)

This makes sense if an sqlite compile option affects SQliteCpp, but if it's doesn't it's quite cumbersome to add an option for every available SQlite setting.

But luckily there's a simpler solution: I can just call target_compile_definitions(sqlite3 PUBLIC ...) directly from my own CMakeLists.txt. I just gave it a quick try with example1 and the following CMakeLists.txt. This works for me (Windows/VS2022):

cmake_minimum_required(VERSION 3.12)

project(SQLiteCpp_ex1)

set(SQLITE_OMIT_LOAD_EXTENSION ON)
add_subdirectory(../../ SQLiteCpp)

add_executable(SQLiteCpp_ex1 main.cpp)

target_compile_definitions(sqlite3 PUBLIC 
    SQLITE_DQS=0
    SQLITE_THREADSAFE=0
    SQLITE_DEFAULT_MEMSTATUS=0
    SQLITE_DEFAULT_WAL_SYNCHRONOUS=1
    SQLITE_LIKE_DOESNT_MATCH_BLOBS
    SQLITE_MAX_EXPR_DEPTH=0
    SQLITE_OMIT_DEPRECATED
    SQLITE_OMIT_PROGRESS_CALLBACK
    SQLITE_OMIT_SHARED_CACHE
    SQLITE_USE_ALLOCA
    SQLITE_STRICT_SUBTYPE=1
    )

target_link_libraries(SQLiteCpp_ex1 PUBLIC SQLiteCpp)

Of SQlite's recommended compile time options, I had to remove a couple:

• SQLITE_OMIT_DECLTYPE: conflicts with the default SQLITE_ENABLE_COLUMN_METADATA. I quickly tried disabling SQLITE_ENABLE_COLUMN_METADATA but this caused compiler/linker errors.
• SQLITE_OMIT_AUTOINIT caused a runtime error

But that's fine by me.