Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️♻️ How to handle identical names? #601

Open
3 tasks
JackDevAU opened this issue Feb 12, 2024 · 1 comment
Open
3 tasks

⚠️♻️ How to handle identical names? #601

JackDevAU opened this issue Feb 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@JackDevAU
Copy link
Member

Hey Team,

Description

As brought up in issue #562 by @tomek-i we don't currently support identical names. Though the possibility is small, this is probably something we should consider and handle.

What needs to be fixed is SSW.People and how the url's / slugs to the people are generated.
Even firstname + lastname combination would eventually be a problem if we get 2 people with the same first/lastname like John Snow.
-@tomek-i

Tasks

Preview Give feedback
@tiagov8
Copy link
Member

tiagov8 commented Feb 12, 2024

Note: My 1st thinking is to use "/john-smith-2" but not 100% happy with it.

I think this is a extremely rare scenario and we can deal with them individually (case by case)
E.g. There is a chance the 2nd employee will be able to include a middle name abbreviation. E.g. "/adam-j-cogan"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants