Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Tina - Add React components for Figure text #1511

Closed
2 tasks
Calinator444 opened this issue Sep 28, 2024 · 2 comments
Closed
2 tasks

✨Tina - Add React components for Figure text #1511

Calinator444 opened this issue Sep 28, 2024 · 2 comments
Labels
Type: Feature A suggested idea for this project

Comments

@Calinator444
Copy link
Member

Calinator444 commented Sep 28, 2024

Cc: @bradystroud, @adamcogan

Hi

Pain

❌ Adding figure text in markdown is easy to mess up and this error usually isn't visible until we merge

Suggested Solution

Tina supports mdx, meaning we can embed React components inside of markdown. I would recommend creating a Figure text component so that users can easily add figure text for good & bad examples using the embed button.

  • Create a figure text field that can go on all blocks (e.g. greybox, images, codeblocks)
  • It should also have a dropdown that lets you pick from good, bad, ok, and nothing (see image)
    Make the dropdown include icons for extra awesome

Important Note

I would still allow legacy support for figure text in markdown so that we have a migration path while users at SSW adopt the new component.

Image
Figure: Dropdown will let users pick from these images

@Calinator444 Calinator444 added the Type: Feature A suggested idea for this project label Sep 28, 2024
@bradystroud bradystroud changed the title ✨Tina Migration - Add React components for Figure text ✨Tina - Add React components for Figure text Oct 2, 2024
@jeoffreyfischer
Copy link
Member

jeoffreyfischer commented Oct 4, 2024

This is a Great Idea! Also, make sure that:

  • the default value in the dropdown should be "nothing"

@JackDevAU
Copy link
Member

Closing in favour of #1628

@JackDevAU JackDevAU closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A suggested idea for this project
Projects
None yet
Development

No branches or pull requests

3 participants