Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧠 Spike - Investigate whether white space issues causing Rules deployments to fail #1606

Open
4 tasks done
Calinator444 opened this issue Oct 31, 2024 · 1 comment
Open
4 tasks done
Assignees

Comments

@Calinator444
Copy link
Member

Calinator444 commented Oct 31, 2024

Description

In a previous PBI We discovered that white space issues in the frontmatter for SSW Rules were causing
See PBI - 🐛 Bug - "Gatsby Build" job is failing due to whitespace issue

Tasks

  • Identify which white space rules still cause rules to fail to deploy
  • Identify which white spaces caused rules to fail to deploy

Acceptance Criteria

  • PBIs created to add frontmatter validation for white space issues (if applicable)
  • Wiki updated with known white space issue
@Calinator444 Calinator444 self-assigned this Nov 4, 2024
@Calinator444
Copy link
Member Author

Calinator444 commented Nov 4, 2024

@bradystroud

All done - Based on my local testing rules, it should still build correctly in spite of most white space issues. Those being:

  • Spaces at the end of the frontmatter
  • Spaces in the middle of the frontmatter
  • Spaces after the text of custom components (such as greyboxes)

Image
Figure: White space issues that will still allow builds

The only white space issue that should cause build errors is missing space after frontmatter fields, however I've updated the frontmatter validator to pick up on this: SSWConsulting/SSW.Rules.Content#9531.

Image

Figure: New frontmatter validator working correctly

Also note that I haven't updated the wiki because the issues I mentioned above are already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant