Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use template files like netweaver formula #100

Open
MalloZup opened this issue Sep 14, 2020 · 0 comments
Open

use template files like netweaver formula #100

MalloZup opened this issue Sep 14, 2020 · 0 comments

Comments

@MalloZup
Copy link
Contributor

So I was researching how to inject the gid and id for active directory integration and I found out that the best and elegant approach is to inject template files like https://github.com/SUSE/sapnwbootstrap-formula/blob/82f104952d812f4413920b8e38e63a95fc8984c5/netweaver/install_ascs.sls#L16

So having a template file, I would then from the deployment project modify those variable on the file adding if the ad present these vars. Then the formula here (hana) would just take the template file with the modified vars.

I have considered the pillar or other approaches/grains but I still considered that if we expose such files as template, it will be much more clear and easy to understand the whole machinery.

As alternative there is the grain approach where during the deployment, we set grains like ad_sapys_gid , ad_userid so and the formula here would take in case the exists.

On longerm, I think perhaps having a template file would simplify the install.

I was also thinking that the install function is to much "intelligent" or take to much responsability.

Imho we should split this call, in different phase:

  • create conf file
  • validate etc if needed
  • install
  • do post install if needed

Actually right now the install function is doing everything of this, which make difficult imho to have a fine grained debugging experience.

I will meanwhile explore the grain approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant