-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saptune solution_enabled follow-up/improvements #4
Comments
@angelabriel can we access somehow the whole list of solutions |
the list should be here: or even via command line we could have
I have created this follow-up issue basically because I knew it is possible only given time constraints/task and for a first release was to much. So yep, I think the best solution would just to shell-out things as we do with other metrics, not depending on a filepath which might change and we can do some regex for the whole mechanism to have the solutions names |
@MalloZup have you thought about including saptune as a go library and using the API directly from the Go code, instead of invoking the CLI command? This should make things easier, at some initial cost. |
saptune was not developed as a library. So it's complicated to use the GO code in this direction. Using saptune as a command gives (for some operations) a better defined CLI. And as discussed previous Sören and I working on a machine readable API, which will make it much easier to consume the saptune output in scripts (for SAP HEC or customers), exporter or other use cases. |
@stefanotorresi yep is something I initially tried a poc with this and I discussed it with @angelabriel this approach, however it could have been risk to rely on some Public function which might change. but In this particular case, maybe we could use it. I did already a similar approach here: https://github.com/SUSE/saptune_exporter/blob/master/meta_collector.go#L6 https://github.com/SUSE/saptune_exporter/blob/master/meta_collector.go#L39 something could be researched on complex things to avoid regex, but otherwise is better to rely on shell output as more stable. Anyways saptune provide a good parsable output for the metrics we build, not for all corner cases which we could just use some functions or regex. |
I see. Well, I guess we could wait for this functionality then! Would an extra pair of hand be of any use with this regard? |
Currently the metrics we have for saptune_solution are "disappearing".
We should investigate if we can have all other solutions labels set to 0 and the active 1 , then when changes it will change also the state.
Current status:
The text was updated successfully, but these errors were encountered: