Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Consider instrumenting the collectors and record collection errors with dedicated metrics. #5

Open
stefanotorresi opened this issue Nov 26, 2020 · 3 comments

Comments

@stefanotorresi
Copy link
Contributor

We need to ensure that saptune is available in the specified path.

Feel free to copy-paste from here:
https://github.com/ClusterLabs/ha_cluster_exporter/blob/3c305da4b9af7c24a8fb98389f9db5360733752c/collector/default_collector.go#L77

@MalloZup
Copy link
Contributor

func checkExecutables(paths ...string) error {

this is already implemented in mostly all places unless i'm missing something?

@stefanotorresi
Copy link
Contributor Author

stefanotorresi commented Nov 27, 2020

Right! I totally missed that! I only checked in the collector constructors, but I see that the check happens in the actual collection cycles.
Maybe we should add the instrumented collector, then, so that we expose collection failures as well, instead of just logging the error?

@stefanotorresi stefanotorresi changed the title Sanity check on saptune dependency Consider instrumenting the collectors and record collection errors with dedicated metrics. Nov 27, 2020
@MalloZup
Copy link
Contributor

make sense to add it. there are other things I didn't ported like error handling with context and maybe other details for a skeleton

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants