Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pengine Dies and Notebook jumps to it. #110

Open
PaulBrownMagic opened this issue Jul 31, 2019 · 3 comments
Open

Pengine Dies and Notebook jumps to it. #110

PaulBrownMagic opened this issue Jul 31, 2019 · 3 comments

Comments

@PaulBrownMagic
Copy link

I wrote a long notebook that takes some time to work through. I noticed if I'd run a query near the top and left the Pengine thread open, when I was in the middle of reading something complicated halfway down the page and the Pengine died, I was suddenly scrolled up to that old query.

This is rather annoying and I think it would be better for Pengines to die quietly, especially when using SWISH notebooks for study.

I tried reading the source code to find the relevant part, I believe if deleting line 1231 in runner.js will stop the behaviour:

if ( !aliveState(state) ) {
       var elem = this;
       $(".prolog-editor").trigger('pengine-died', data.prolog.id);
       data.prolog.destroy();
       setTimeout(function() { elem.trigger('scroll-to-bottom') }, 100); // delete this?
@JanWielemaker
Copy link
Member

Deleting might work. This functionality is indeed something annoying and sometimes useful. The latter notably if you are doing serious things with SWISH and do not like to wait for some long running query. Deleting might suite more users, at least for now.

@PaulBrownMagic
Copy link
Author

Let's find out what might suit more users. I put a poll in the discourse.

@damons
Copy link

damons commented Aug 19, 2019

Do you have a link to the poll?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants