Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review 0 #1

Open
franziskuskiefer opened this issue Dec 1, 2016 · 1 comment
Open

Review 0 #1

franziskuskiefer opened this issue Dec 1, 2016 · 1 comment

Comments

@franziskuskiefer
Copy link

franziskuskiefer commented Dec 1, 2016 •
edited by sooryan
Loading

I gave the code in here a first pass. You can find the review at [1].

[1] franziskuskiefer#1
Sachin-A added a commit that referenced this issue Dec 2, 2016
@Sachin-A
Review0 fixes #1
e8073b9 
Fix incorrect hash output (value of 00 in part of hash result in loop out)
File & Folder rename
Conform to Mozilla style guide
Maintain consistency with extern linkage declarations
Sachin-A added a commit that referenced this issue Dec 3, 2016
@Sachin-A
Review0 fixes #1
27fb9a5 
Fix incorrect hash output (value of 00 in part of hash result in loop out)
File & Folder rename
Conform to Mozilla style guide
Maintain consistency with extern linkage declarations
Sachin-A added a commit that referenced this issue Dec 3, 2016
@Sachin-A
Review0 fixes #1
9c5e9e8 
Fix incorrect hash output (value of 00 in part of hash result in loop out)
File & Folder rename
Conform to Mozilla style guide
Maintain consistency with extern linkage declarations
@sooryan sooryan closed this as completed in 901add2 Dec 4, 2016
sooryan added a commit that referenced this issue Dec 4, 2016
@sooryan
Address issues raised in review #1
4a780c1 
Fix incorrect hash output (value of 00 in part of hash result in loop out)
File & Folder rename
Conform to Mozilla style guide
Maintain consistency with extern linkage declarations
Sachin-A added a commit that referenced this issue Dec 5, 2016
@Sachin-A
Addressing Review0 changes #1
722e5a0 
Fix incorrect hash output (value of 00 in part of hash result in loop out)
File & Folder rename
Conform to Mozilla style guide
Maintain consistency with extern linkage declarations
@Sachin-A Sachin-A reopened this Dec 5, 2016
@Sachin-A
Copy link
Owner

Sachin-A commented Dec 5, 2016 •
edited
Loading

Reopening since all changes have not been addressed.
See review 0 for reference

@sooryan sooryan closed this as completed Dec 5, 2016
@sooryan sooryan reopened this Dec 5, 2016
Sachin-A added a commit that referenced this issue Dec 21, 2016
@Sachin-A
Addressing Review0 changes #1
2d6dd8f 
Fix incorrect hash output (value of 00 in part of hash result in loop out)
File & Folder rename
Conform to Mozilla style guide
Maintain consistency with extern linkage declarations
Sachin-A pushed a commit that referenced this issue Jan 3, 2017
Merge pull request #1 from suhithr/master
b8445e7 
Starts off organization of a simple implementation
Sachin-A pushed a commit that referenced this issue Jan 3, 2017
Merge pull request #1 from Spockuto/master
bf9e124 
Merges basic blake2s function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@franziskuskiefer @Sachin-A @sooryan