Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORCA-318] Add instructions on setting up env on EC2 #42

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

danlu1
Copy link
Contributor

@danlu1 danlu1 commented Apr 19, 2024

Problem:

The instruction doesn't include the update of the synindex workflow. It doesn't have guides on setting up the environment on EC2 and lacks details on AWS_Profile that can be used to run demo.py.

Solution:

Fill in more details in README.md.

@danlu1 danlu1 requested a review from a team as a code owner April 19, 2024 19:21
Copy link

swarmia bot commented Apr 19, 2024

✅  Linked to Story ORCA-318 · Update readme file for py-orca

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 pre-approving but this looks good to merge once tests pass

Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@danlu1 danlu1 merged commit 2bb73d0 into main Apr 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants