RMHDR-257 Fix parsing and filtering of device type strings #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evice type strings per participant
…value" contains string "other" in any form
There was a problem hiding this comment.
I looked at the changes to the way we are picking up device manufacturers, the new code update treats them as case(lower/upper/mix) agnostic. We coerce all values as 'Apple Watch' or 'Garmin' or 'Polar' or 'HRM808S' or 'Other'. 'Fitbit' apparently(from Pranav) has no variations in case as it does appear as 'Fitbit' - so that device manufacturer is not considered in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
valuecontainsotherin its row value in any form