Wrong Rotation Checking

[miticociuck]

In several parts of the Guillotine3D.cs there is a wrong checking of dimensions
.....
else if (box.AllowedRotationsY &&
container.Width >= box.Width &&
container.Length >= box.Width &&
container.Width >= box.Length)
return true;
....

I think it should be:
container.Width >= box.Height &&

[SahibYar]

thanks for keeping an eye on the code, yeah that is a mistake there. I will shortly upload the latest commit fixing all the issues you raised.

[miticociuck]

Hi Sahib,

I didn’t see any activity in the last 3 weeks, and I didn’t receive any news from You.

So I’m asking…. are You still working on this project or You gave up?

Luca

Da: Sahib Yar [mailto:[email protected]]
Inviato: mercoledì 20 gennaio 2016 16:15
A: SahibYar/3D-Bin-Packing [email protected]
Cc: Luca Breda [email protected]
Oggetto: Re: [3D-Bin-Packing] Wrong Rotation Checking (#3)

thanks for keeping an eye on the code, yeah that is a mistake there. I will shortly upload the latest commit fixing all the issues you raised.

—
Reply to this email directly or view it on GitHub #3 (comment) . https://github.com/notifications/beacon/AP0ynC6k6hg_cp3WQtujwoljXj2PbCq_ks5pb5wJgaJpZM4HH3xY.gif