Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application logic update on frontend #122

Open
2 tasks done
eggwhat opened this issue Jan 24, 2024 · 13 comments
Open
2 tasks done

Application logic update on frontend #122

eggwhat opened this issue Jan 24, 2024 · 13 comments
Assignees

Comments

@eggwhat
Copy link
Contributor

eggwhat commented Jan 24, 2024

  • Add auth for confirming order
  • Change order status page
@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

There is also an issue while accepting an offer and it fails some validation, the button to accept is hidden under an exception

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

Getting offers from 3rd api should be working now on the backend. I need to check if accepting offer works.

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

There is also an issue while accepting an offer and it fails some validation, the button to accept is hidden under an exception

It is still an issue

@an2508374
Copy link
Collaborator

There is also an issue while accepting an offer and it fails some validation, the button to accept is hidden under an exception

It is still an issue

Can you give more details about it?

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

image

@an2508374
Copy link
Collaborator

There is also an issue while accepting an offer and it fails some validation, the button to accept is hidden under an exception

I've fixed it, it should be solved now.

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

Thank you, I think the createOrder in api.tsx is not sending company in json but don;t know why

@an2508374
Copy link
Collaborator

Thank you, I think the createOrder in api.tsx is not sending company in json but don;t know why

Fixed, thanks for noticing it.

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

I noticed that you changed getorders enpoint. I wanted to differentiate order request and orders. Is it possible to make exactly the same table but using get orders/requests? so two tables for orders in total.

@an2508374
Copy link
Collaborator

an2508374 commented Jan 24, 2024

I noticed that you changed getorders enpoint. I wanted to differentiate order request and orders. Is it possible to make exactly the same table but using get orders/requests? so two tables for orders in total.

Ok, so I can split current "Bank Offer Requests" to new "Bank Offer Requests" (waiting for decision, approved, cancelled) and "Bank Orders" (confirmed, picked up, delivered, cannot deliver).

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

just use get orders for one and get orders/requests for the other. But revert get orders to previous version first

documents = documents.Where(p => p.CustomerId == query.CustomerId &&
                p.Status != OrderStatus.WaitingForDecision && p.Status != OrderStatus.Approved);

The get orders/request triggers very important call for retrieving orders from lecturerAPI

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 24, 2024

The baronomat api should be working now

@eggwhat
Copy link
Contributor Author

eggwhat commented Jan 25, 2024

It seems like everything is working. Can we add some more default values for the inquiryPage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants