Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need to automate it to convert spaces to tabs #164

Open
erfangnu opened this issue Jun 14, 2024 · 16 comments
Open

we need to automate it to convert spaces to tabs #164

erfangnu opened this issue Jun 14, 2024 · 16 comments
Assignees

Comments

@erfangnu
Copy link
Member

we need to automate it to convert spaces to tabs

bbf56b1

@jbampton
Copy link
Member

refs #46

@jbampton jbampton removed their assignment Jul 1, 2024
@BaseMax
Copy link
Member

BaseMax commented Aug 9, 2024

Please check it mate @jbampton

@BaseMax
Copy link
Member

BaseMax commented Sep 7, 2024

After merging @BDadmehr0 changes, now everything is spaces. We need to change all to Tabs.

@BDadmehr0
Copy link
Contributor

I ran clang-format once and the codes are cleaned, but this happens automatically before commit

@BaseMax
Copy link
Member

BaseMax commented Sep 7, 2024

Please add all requirements and useful commands to REAMDE or somewhere.
And if it doesn't run automatically in pre-commit, we can add CLANG in pre-commit settings.

@BaseMax
Copy link
Member

BaseMax commented Sep 7, 2024

It also seems that we need the same linter for python files. #214

@BDadmehr0
Copy link
Contributor

I'm working on it.

@BDadmehr0
Copy link
Contributor

Please add all requirements and useful commands to REAMDE or somewhere. And if it doesn't run automatically in pre-commit, we can add CLANG in pre-commit settings.

I created a README.md about this. I just have a question: where should I add or upload this README.md?

@BaseMax
Copy link
Member

BaseMax commented Sep 7, 2024

@BDadmehr0
Copy link
Contributor

CONTRIBUTING Maybe https://github.com/SalamLang/Salam/blob/main/CONTRIBUTING.md

I have read the CONTRIBUTING guide, but I couldn't find any information about where to upload the documentation for common commands and the prerequisites for clang-format.

@BaseMax
Copy link
Member

BaseMax commented Sep 8, 2024

Yes, we don't have it, but we can edit the CONTRIBUTING file to create and add useful information about the development and format of clang and other tools in that file.

Feel free to change anything you want.

@BDadmehr0
Copy link
Contributor

#227

@BaseMax
Copy link
Member

BaseMax commented Sep 8, 2024

Thanks

@BaseMax BaseMax closed this as completed Sep 8, 2024
@BaseMax BaseMax reopened this Sep 8, 2024
@BaseMax
Copy link
Member

BaseMax commented Sep 8, 2024

This issue is related to an automated process that converts all space indents to tabs. Have we already implemented this feature in the pre-commit stage?

@BDadmehr0
Copy link
Contributor

This issue is related to an automated process that converts all space indents to tabs. Have we already implemented this feature in the pre-commit stage?

Check the pre-commit configuration files or git hooks(.git/hooks/) to see if the process for converting spaces to tabs is implemented.

@BaseMax
Copy link
Member

BaseMax commented Sep 8, 2024

@jbampton clear answer please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants