Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support PWA Kit project for monorepo setup via pnpm or other dependency managers #2120

Open
kevinxh opened this issue Nov 8, 2024 · 1 comment

Comments

@kevinxh
Copy link
Collaborator

kevinxh commented Nov 8, 2024

Is your feature request related to a problem? Please describe.

Note: this isn't about the pwa-kit monorepo, it's about making customer projects to support monorepo.

The pwa-kit-dev CLI commands is not compatible with other node dependency managers like pnpm. The build and start command have hardcoded paths to specific dependencies like webpack and babel-node.

const babelNode = p.join(
                require.resolve('webpack'),
                '..',
                '..',
                '..',
                '.bin',
                'babel-node'
            )

or
const webpack = p.join(require.resolve('webpack'), '..', '..', '..', '.bin', 'webpack')

Describe the solution you'd like

Support common node monorepo toolings / dependency managers like pnpm.

@mgalassi
Copy link

This would be extremely valuable, as it opens to a broader set of different configurations when setting up the project in a monorepo.
I hope the team will also consider the 2.x.x versions for this upgrade (most folks are still on them!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants