Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix Server-Timing key formatting #2137

Open
johnboxall opened this issue Nov 18, 2024 · 0 comments
Open

[BUG] Fix Server-Timing key formatting #2137

johnboxall opened this issue Nov 18, 2024 · 0 comments

Comments

@johnboxall
Copy link
Collaborator

In #1895, we added the Server-Timing header to HTTP responses.

https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/debugging.html#__server_timing

To namespace metric names we used colons like ssr:route-matching.

It seems like colons (eg. :) are not considered valid characters:

https://www.w3.org/TR/server-timing/#the-server-timing-header-field

The result is that tools like Chrome cannot parse our Server-Timing response:

Screenshot 2024-11-18 at 3 10 26 PM

We should consider using a different character for namespacing and verify that it works in Chrome and other Server-Timing parsing tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant