Docker improvements

[APraxx]

hi,

i think the dockerfile can be enhanced a bit.

• drop root
  It seems the current docker image runs the service as root. this should be dropped down to a regular user if not needed.

• maybe give the option to specify a user pid/gid

i could make a pr if you like

[SamTV12345]

Hi,

sure please do so. I don't know if the standard docker image with distroless needs that but the ubuntu image could definitely benefit from that.

[APraxx]

So i did some research because i wanted this to be the same across all the images.
But after digging into it I'm back at the start.

is there a reason to not just forcing the user via docker at runtime?

basically just user: ${UID:-1000}:${GID:-1000} in compose

reason: everything else ranges from a simple USER in the dockerfile to scripting for runtime changes

[SamTV12345]

I guess not. That would be the easiest solution. Do you want to create a pr?

[APraxx]

done

[APraxx]

@SamTV12345 other thing i noticed and is indirect a docker issue.
your dev? branch has still podgrabv2 as it's name.

this kinda leaks into the main branch

[APraxx]

would you be open for a ghcr.io images? this could be done via github actions and could for a start track master

[SamTV12345]

Are you good at github actions? I must admit I have never been that comfortable with that syntax etc. I would like to have an action that runs on master and on the pull requests.The pull requests should check if the build even works.

[APraxx]

ill look into it

[SamTV12345]

Thanks for the help.

[APraxx]

build on every commit to main?

[SamTV12345]

On release of a tag v** would be enough. Normally versions are v3.5.1 etc.