Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FITC Nested conditionals being compiled incorrectly #74

Open
jugeeya opened this issue Sep 9, 2017 · 1 comment
Open

FITC Nested conditionals being compiled incorrectly #74

jugeeya opened this issue Sep 9, 2017 · 1 comment

Comments

@jugeeya
Copy link

jugeeya commented Sep 9, 2017

This bug was introduced in the earlier commit that fixed recompiling Robin, Sonic, etc. I don't know why, but it changes around the braces such that the logic of the conditionals doesn't work well at all anymore. Below, on the left is the code before compilation, and on the right is the code after decompilation of that compilation. Notice the added brace at line 21 for the true block, and the lack of braces at line 38 for the false blocks.

image

@Sammi-Husky
Copy link
Owner

Update: I believe this and #75 are caused by the same thing, so at the very least i should get these working 100% before worrying about the edge cases later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants