Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Suggestion) Disable water near spawners #14

Open
IAISI opened this issue Mar 15, 2024 · 2 comments
Open

(Suggestion) Disable water near spawners #14

IAISI opened this issue Mar 15, 2024 · 2 comments

Comments

@IAISI
Copy link

IAISI commented Mar 15, 2024

On factions server players often water spawers to make them hard to raid, while preventing liquid flow/placement near spawners could be done with plugins, performance usually isn't great, it's been awhile since I've really messed with custom .jars aside from editing a few minor things here and there, but I figured this would be good suggestion.

Something like min-range with 0 resulting in vanilla behavior, 1 blocking liquids 1 block around spawner, 2 in 2 blocks and so on... should also check diagonal blocks, possibly with option to ignore blocks below the spawner (probably not worth the hassle tho).

@Samsuik
Copy link
Owner

Samsuik commented Mar 18, 2024

I'm not sure on implementing anything like this in Sakura. There are alternatives such as allowing spawners to blow up while watered which would be less intensive than looking for spawners or sponges on water flow, and plugins could check if there are any tile entities in the adjacent chunks before looking for spawners in the radius as an optimisation.

@IAISI
Copy link
Author

IAISI commented Sep 11, 2024

Performance would depend on radius that would be checked? I think at least some of the blocks are already checked in

public abstract class FlowingFluid extends Fluid

tho only 1 block at the time...

Similar patch was added for sponge blocks in blossom: https://github.com/Samsuik/Blossom/blob/8779d5efcd74b034e0d3730ac30da29791cc52bd/patches/server/0118-Customise-Sponge-Mechanics.patch

essentially what I was suggesting was doing same mechanics but for spawners, but I could see how performance would be an issue. I guess it would be nice idea but not really doable efficiently...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants