Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Use of uv__udp_finish_close is Unix specific #47

Closed
nkolban opened this issue Nov 9, 2016 · 4 comments
Closed

Use of uv__udp_finish_close is Unix specific #47

nkolban opened this issue Nov 9, 2016 · 4 comments

Comments

@nkolban
Copy link

nkolban commented Nov 9, 2016

There is a reference to a function called uv__udp_finish_close() ... see:

uv__udp_finish_close((uv_udp_t*)handle);

That is defined only in the Unix specific implementation ...

https://github.com/Samsung/libtuv/blob/374e9978322d8173f385fd53297335b94e1787d1/source/unix/uv_unix_udp.c

I believe this needs to be abstracted.

@chokobole
Copy link

@nkolban I think the function signature itself is enough to be abstracted. (Because platform specific function signature we name this kind of function as uv_unix_udp_finish_close.) I believe the thing is needed is we implement more functions as we support more platforms.

@nkolban
Copy link
Author

nkolban commented Nov 10, 2016

Howdy ... are you saying that the issue has been accepted as something that will be worked upon? My goal is to port or get running libtuv on the new ESP32 platform and if changes are going to be made in this area, I'll hold off until done.

@chokobole
Copy link

Ah I assumed that you misunderstood my word the thing is needed is we implement. We don't plan to make a big work on this area. so If you want to extend our platform support, very welcome!

@nkolban
Copy link
Author

nkolban commented Nov 10, 2016

I think we can track this as a duplicate of #49

@nkolban nkolban closed this as completed Nov 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants