Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage --disable-ofi-inject changes in the transport layer #1112

Open
wrrobin opened this issue Feb 16, 2024 · 2 comments
Open

Manage --disable-ofi-inject changes in the transport layer #1112

wrrobin opened this issue Feb 16, 2024 · 2 comments
Assignees

Comments

@wrrobin
Copy link
Collaborator

wrrobin commented Feb 16, 2024

Current changes for the flag are done in the best effort manner. Need them to be organized in transport_ofi.

@wrrobin wrrobin self-assigned this Feb 16, 2024
@markbrown314
Copy link
Collaborator

@wrrobin this ticket is not very clear. Could you provide details of the changes that are needed here?

@markbrown314 markbrown314 self-assigned this Feb 14, 2025
@wrrobin
Copy link
Collaborator Author

wrrobin commented Feb 14, 2025

The thought was that since this is a OFI specific flag, the use of it should be restricted to the OFI transport layer. Current changes are done above that. This was also specific to a particular provider. So, better restructuring of the code could have been done.

@markbrown314 markbrown314 removed their assignment Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants