-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.2.4 added proprietary components #244
Comments
Hi @IzzySoft , I had replaced firebase with Appwrite and completely removed the google drive sync option. We haven't made any changes related to firebase in this release, I can see this entry If this |
I got it, we recently added |
Yepp, you found it! in_app_review needs Google Play Core, which in turn depends on GMS. If you could omit that from the FOSS branch that would be great… Oh, I see you already did that, thanks! 🤩 Apologies for me mixing things up there, I'm not that familiar with Flutter. Seems like I also looked at the wrong file: I didn't remember you were using branches for the different variants but assumed build flavors 🙈 |
Thanks for the help! I have created a new release by reverting this change |
Thanks! Just manually triggered an update to verify. Scanner reports
That blob can easily be avoided by a minor addition to your android {
dependenciesInfo {
// Disables dependency metadata when building APKs.
includeInApk = false
// Disables dependency metadata when building Android App Bundles.
includeInBundle = false
}
} For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains. More details can be found e.g. here: Ramping up security: additional APK checks are in place with the IzzyOnDroid repo. OK, meanwhile the update is through: success, thanks! The proprietary parts are gone, so anti-feature removed even before it went live. Congrats, that was speed Leaving the issue open for "that other proprietary blob". Feel free to close once the fix for that was implemented 😉 |
Hi, thanks a lot! I'll be releasing another version by next week, I'll certainly remove it. |
Thanks! Confirming: Seems we have everything covered now, right, so we can close the issue? Or did I miss something? |
Yes, everything seems done! |
v2.2.4 suddenly comes with Google Mobile Services and Google Play Core – rendering your app at least partially non-FOSS. Was that intended, or were they dragged in by some dependency? I tried to check that and took a look at your
pubspec.yaml
andandroid/app/build.gradle
but couldn't find them mentioned there (however I found Firebase there, which would also be proprietary).For now I've added the related anti-feature at IzzyOnDroid. But these two (and Firebase even more) are considered privacy issues – which do not go well with PII as usually found in a diary (you cannot control or even check what happens in those libraries as the source is not available – but being part of your app they have access to everything the app can access).
The text was updated successfully, but these errors were encountered: