Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance welcome note #73

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Enhance welcome note #73

merged 6 commits into from
Oct 17, 2023

Conversation

SankethBK
Copy link
Owner

@SankethBK SankethBK commented Oct 7, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Featured Covered in this PR

  • Improve contents of welcome note

Related Tickets & Documents

  • Related Issue #
  • Closes #

Screenshots, Recordings

Tested Feature??

  • In Real Device.
  • In Emulator

@SankethBK SankethBK requested a review from micedreams October 7, 2023 21:09
@SankethBK SankethBK changed the title Enhance_welcone_note Enhance welcome note Oct 7, 2023
@SankethBK
Copy link
Owner Author

SankethBK commented Oct 7, 2023

@micedreams I have changed the content of welcome note, see if you have any ideas to improve it further

@micedreams
Copy link
Collaborator

micedreams commented Oct 11, 2023

@micedreams I have changed the content of the welcome note, see if you have any ideas to improve it further

@SankethBK Privacy-focused is good and all... but here you should also talk about offline first... pointing out the user can use the app to its full capacity even if they are unwilling to sync.

Copy link
Collaborator

@micedreams micedreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good...
Except for that little thing...
and merge conflicts

@SankethBK SankethBK merged commit 5fef48e into master Oct 17, 2023
2 checks passed
SankethBK added a commit that referenced this pull request Oct 20, 2023
* Enhance Welcome note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants