Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punjabi ('pa') Language added #79

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

markandey1414
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added 1 new language, Punjabi ('pa') at the path lib\l10n\arb\app_pa.arb and updated app.dart

Featured Covered in this PR

  • Task 1
  • Task 2

Related Tickets & Documents

  • Related Issue #
  • Closes #

Screenshots, Recordings

Please replace this line with instructions on how to test your changes, or any screenshots or recording you can attach here.

Tested Feature??

  • In Real Device.
  • In Emulator

@markandey1414
Copy link
Contributor Author

have a look now, I made another PR for punjabi

"resetPassword":"ਪਾਸਵਰਡ ਰੀਸੈੱਟ",
"autoSync":"ਆਟੋ ਸਿੰਕ",
"alreadyHaveAnAccount":"ਕੀ ਪਹਿਲਾਂ ਤੋਂ ਹੀ ਖਾਤਾ ਹੈ?",
"syncNow":"ਸਿੰਕ",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be wrong, its translating to sink instead. I got this on google translate ਹੁਣੇ ਸਿੰਕ ਕਰੋ can you check once

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, updated now

"changeEmail":"ਈਮੇਲ ਬਦਲੋ",
"setupYourAccount":"ਆਪਣਾ ਖਾਤਾ ਸੈਟ ਅਪ ਕਰੋ",
"logIn":"ਲਾਗਿਨ",
"logOut":"ਲਾੱਗ ਆਊਟ, ਬਾਹਰ ਆਉਣਾ",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting Log out, log out on google translate, we only need it once

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Owner

@SankethBK SankethBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing

@SankethBK SankethBK merged commit 8b843ef into SankethBK:master Oct 9, 2023
1 of 2 checks passed
SankethBK pushed a commit that referenced this pull request Oct 20, 2023
* punjabi ('pa') language added

---------

Co-authored-by: Atharva Markandey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants