Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/daily reminders #94

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Feat/daily reminders #94

merged 9 commits into from
Oct 19, 2023

Conversation

SankethBK
Copy link
Owner

@SankethBK SankethBK commented Oct 15, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Added daily recurring notifications

Featured Covered in this PR

  • Daily notification reminders which can be enabled/disabled
  • Uses SCHEDULE_EXACT_ALARM on Android permission. So notifications can be sent even if app is closed

Related Tickets & Documents

Screenshots, Recordings

Tested Feature??

  • In Real Device.
  • In Emulator

@SankethBK SankethBK requested a review from micedreams October 15, 2023 15:54
@micedreams
Copy link
Collaborator

micedreams commented Oct 19, 2023

This is for next time!!

Every commit must be complete and every commit message must be meaningful.

Whenever you commit one or more files, add a one-line comment following these simple rules:

  1. The one-liner is up to 60-70 characters long.
  2. The one-liner starts with a verb in an infinitive form, f.ex: "Fix", "Correct", "Refactor", "Implement", "Add", "Change", "Upgrade", "Reformat", etc.
  3. The verb's first letter is capitalized.
  4. The whole sentence ends with a full-stop character (.).

So, you end up with a perfect and concise English sentence.

If you want to indicate your branch is still a work in progress, please attach the wip label.

Copy link
Collaborator

@micedreams micedreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature works... the code looks pretty good!!
Good job!!

@micedreams
Copy link
Collaborator

@SankethBK is this PR only for Android push notifications correct?

@SankethBK
Copy link
Owner Author

@SankethBK is this PR only for Android push notifications correct?

yes

@micedreams
Copy link
Collaborator

@SankethBK do you think using this https://pub.dev/packages/sprintf is a good idea?
Not all languages have the same word order right...

Copy link
Collaborator

@micedreams micedreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@micedreams micedreams merged commit 2127d75 into master Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants