Client crash on Examining your self

[t999uk]

Describe the problem: Please describe the problem you're encountering accurately, including steps to reproduce/recreate the issue.

Screenshots or videos needed to identify the problem: Please attach screenshots or videos showing the problem to this issue, if applicable.
https://1drv.ms/u/s!AhXl3lygSuRHk14mB5Wk-b60YB2O

Sapphire branch and commit: You can get this by checking the server startup message in your console window, running git describe --all in a console window or looking at your git client.

server branch master
commit aea0bf3
client fullscreen

Logs: You can get these from the /bin/logs directory in your sapphire clone, please attach them to this issue.

Setup: Please note down which operating system you are using and any other information about your setup which could be of use to us, like compiler/Visual Studio version and FFXIV version.

windows 10
visual studio 2017
ffxiv client retail 4.4

[JeidoUran]

After poking around a bit I found where the issue comes from: when using //gm gc, it doesn't set a GC Rank to go along with it and the game probably doesn't like that. Guess the issue has always been there, but it's only noticeable now that the command has to be used to purchase a house. Using //gm gc 0 or //gm gcrank 1 fixes it for now.

[NotAdam]

I tried this earlier today on a fresh character and it seems fine for me, haven't touched gc, just set level to 70

can you confirm if this still happens for you?

[NotAdam]

I realised I can't read, I've played around with this more (setting gc and leaving rank at 0 and so on) and I still can't get it to crash but I'll push a potential fix for this in a bit, which should also fix some UB in case you use invalid arguments

[JeidoUran]

Sorry, didn't see your first comment. It is still crashing for me. Here are the steps that crashes it:

• Do //gm gc 1 (or any other gc)
• Examine yourself right after
  It should crash. If that may help, the GCRank displayed in the DB in this situation is 0xCDCDCD.

To fix it I have to either do //gm gc 0 or //gm gcrank with a valid rank.

[NotAdam]

ah, uninitialised memory, interesting. Does this still happen on a new character with latest develop?

[SapphireMordred]

Was automatically close by commit 72ca7b6 please reopen if it still exists

[JeidoUran]

Just tried (latest develop + new character) and it still happens.

[SapphireMordred]

Aight, reopened. Ty!

[NotAdam]

I can't get this to happen at all, can you make a new character without the world server running and then check the grandcompanyrank value in the db? And then start world and login and check it again? Is it still setting gcrank to CDCDCD?

I have no idea how this can even be happening as we fetch the value from the db which sets the default value, so it should come through as 0 and we don't write it anywhere unless it's changed