Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting a dataset with negative errors is not allowed #3010

Open
juliuskarliczek opened this issue Aug 14, 2024 · 2 comments
Open

Plotting a dataset with negative errors is not allowed #3010

juliuskarliczek opened this issue Aug 14, 2024 · 2 comments

Comments

@juliuskarliczek
Copy link
Member

juliuskarliczek commented Aug 14, 2024

Describe the bug
I am not sure, whether this problem was addressed in the document from Paul yesterday and i did not see an open issue with this. Feel free to link, if one exists.

When loading one of the example datasets from src/sas/example_data/coordinate_data/sphere_R=0_2025.vtk,
quick plotting this dataset throws an error, because it dataset contains negative values in the errors
(This is a bug, that was also reported to me by a beta test user here at ILL yesterday )
To Reproduce
Steps to reproduce the behavior:

  1. Start sasview
  2. Load data sphere_R=0_2025.vtk into the data explorer
  3. Use quick plotting option "create new" on the bottom of the data explorer
  4. See error

Screenshots
image

SasView version (please complete the following information):

  • release_6.0.0 branch

Operating system (please complete the following information):

  • OS: win10
@krzywon
Copy link
Contributor

krzywon commented Aug 15, 2024

The error thrown is from matplotlib. I would argue this is expected behavior. Negative errors have no physical meaning and are unplottable.

As a side note, the data file loaded in your example is not SAS data. It is multi-column x,y,z coordinate data, not I vs Q data. The ASCII reader can and will read any multi-column data file, but that doesn't mean the data is valid and analyzable. Coordinate data are meant to be opened by the generic scattering calculator, not via the data explorer.

@juliuskarliczek
Copy link
Member Author

Thanks for clearing that up, i did not know that. The user mentioned, that this error did not occur in 5.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants