Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle editor #2520

Merged
merged 35 commits into from
Sep 12, 2023
Merged

Particle editor #2520

merged 35 commits into from
Sep 12, 2023

Conversation

lucas-wilkins
Copy link
Contributor

@lucas-wilkins lucas-wilkins commented May 16, 2023

I've made a new perspective which gives a simple interface for describing arbitrary particles. It's now at a stage where the basic bits work. Basically, just numerically integrate a particle defined by a function, with a bunch of GUI stuff to make it as painless as possible (e.g. visualisations, special syntax highlighting, automated conversion of coordinates). I'm looking for early feedback on the interface and workflow (i.e. high level comments, not a list things that don't work, I know what those are).

It's currently not integrated into SasView properly, but it can be run by executing the script at sas.qtgui.Perspectives.ParticleEditor.DesignWindow

The plan is (assuming I fix the problem below) to add the following functionalities, which are only placeholders right now:

  1. Magnetism
  2. Parametric functions to allow fitting
  3. More helper functions for building shapes
    i) function composition with rotations and translations
    ii) built-in shapes
  4. More kinds of polydispersity (inc ensembles of random particles)
  5. Structure factors
  6. GPU acceleration

image

@lucas-wilkins lucas-wilkins added Enhancement Feature requests and/or general improvements Discuss At The Call Issues to be discussed at the fortnightly call labels May 16, 2023
@wpotrzebowski wpotrzebowski removed the Discuss At The Call Issues to be discussed at the fortnightly call label Jun 6, 2023
@lucas-wilkins lucas-wilkins changed the title Particle editor - preview, and questions Particle editor Sep 4, 2023
@lucas-wilkins
Copy link
Contributor Author

I'd like to merge this before the codecamp, it's not complete, but it's almost completely isolated from everything else, but would good to have things merged for the sake of simplicity.

@lucas-wilkins lucas-wilkins added the Discuss At The Call Issues to be discussed at the fortnightly call label Sep 9, 2023
@lucas-wilkins lucas-wilkins marked this pull request as ready for review September 9, 2023 12:20
@rozyczko
Copy link
Member

rozyczko commented Sep 9, 2023

How to access this perspective? It doesn't show up in the list

@lucas-wilkins
Copy link
Contributor Author

How to access this perspective? It doesn't show up in the list

Run DesignWindow.py (full path above)

@wpotrzebowski
Copy link
Contributor

@wpotrzebowski to review before the code camp

@wpotrzebowski wpotrzebowski removed the Discuss At The Call Issues to be discussed at the fortnightly call label Sep 12, 2023
@wpotrzebowski
Copy link
Contributor

Works as expected and it doesn't seem to affect main code base

@wpotrzebowski wpotrzebowski merged commit b66e577 into main Sep 12, 2023
36 checks passed
@wpotrzebowski wpotrzebowski deleted the particle-editor branch September 12, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants