chore(emoji): Fix issue where numbers and some symbols got big_emoji class applied #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough# Walkthrough
The changes primarily focus on the `markdown` function in `kit/src/components/message/mod.rs`. A temporary workaround has been introduced to handle certain characters that were mistakenly identified as emojis. The function now checks for specific characters and alphanumeric sequences before applying the emoji formatting. The logic for handling emojis has also been adjusted.
# Changes
| File | Change Summary |
| --- | --- |
| `kit/src/components/message/mod.rs` | Introduced a temporary workaround for certain characters mistakenly identified as emojis. The `markdown` function now checks for specific characters and alphanumeric sequences before applying the emoji formatting. The logic for handling emojis has been adjusted. |
# Assessment against linked issues (Beta)
| Objective | Addressed | Explanation |
| --- | --- | --- |
| Identify and fix the bug causing the font size to increase when numbers are sent in the chat (#1468) | ✅ | |
| Ensure that the font size remains consistent regardless of the content of the message (text, numbers, symbols, etc.) (#1468) | ✅ | |
| Understand the goal of the GitHub issue, which is to create a proof of concept for integrating Tailwind CSS with Rust (#001) | ❌ | The changes in this PR do not pertain to the integration of Tailwind CSS with Rust. |
| Analyze the process of running `make tailwind`, which should identify any classes defined in Rust files and include them in the generated stylesheet (#001) | ❌ | The changes in this PR do not pertain to the `make tailwind` process. |
| Identify the technical requirements and constraints for this integration, including any necessary dependencies or configurations (#001) | ❌ | The changes in this PR do not pertain to the technical requirements and constraints for integrating Tailwind CSS with Rust. |TipsChat with CodeRabbit Bot (
|
github-actions
bot
added
Don't merge yet
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- kit/src/components/message/mod.rs (1 hunks)
Additional comments: 2
kit/src/components/message/mod.rs (2)
452-452: The comment provides a link to the issue in the
rust-unicrepository. This is good practice as it provides context for the workaround and allows developers to track the progress of the issue.458-461: The code returns a formatted string with the appropriate span class based on the checks. This is a good use of the
format!macro to create a string with embedded values.
WanderingHogan
force-pushed
the
big_numbers
branch
from
6ad5946 to
e56882d
Compare
|
UI Automated Tests execution is complete! You can find the test results report here |
WanderingHogan
force-pushed
the
big_numbers
branch
from
847663e to
00f4649
Compare
WanderingHogan
force-pushed
the
big_numbers
branch
from
5a15811 to
540b420
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- kit/src/components/message/mod.rs (1 hunks)
Additional comments: 2
kit/src/components/message/mod.rs (2)
- 450-461: The code is returning HTML directly from the function. This could potentially lead to XSS (Cross-Site Scripting) vulnerabilities if
rcontains any user-supplied input. Consider using a safe method to escape any potential HTML inrbefore returning it.return format!("<span class=\"big-emoji\">{}</span>", html_escape::encode_text(&r));
- 453-456: The workaround checks for specific characters and alphanumeric sequences. Ensure that this workaround does not interfere with the normal functioning of the chat feature and that it correctly identifies all emojis.
sdwoodbury
approved these changes
Nov 7, 2023
sdwoodbury
added
Ready for testing
This part? |
stavares843
added
Changes requested
|
@WanderingHogan On all OS's this seems to break markdowns |
WanderingHogan
force-pushed
the
big_numbers
branch
from
0edc449 to
285b437
Compare
WanderingHogan
removed
the
Changes requested
|
@phillsatellite i think it is ready to try again, sorry about that |
dariusc93
approved these changes
Nov 8, 2023
phillsatellite
approved these changes
Nov 8, 2023
phillsatellite
added
QA Tested
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
This is a workaround for the big numbers in chat, if you send them by themselves.
We rely on this crate: https://crates.io/crates/unic-emoji-char/0.8.0
That crate has this bug: open-i18n/rust-unic#280
numbers and some symbols (like # and *) trigger the emoji checks from that crate.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤