Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint router does not have concept of NotFoundHandler #336

Open
nojaf opened this issue Jan 15, 2022 · 1 comment
Open

Endpoint router does not have concept of NotFoundHandler #336

nojaf opened this issue Jan 15, 2022 · 1 comment

Comments

@nojaf
Copy link

nojaf commented Jan 15, 2022

Hello,

I noticed that the Router.fs has a concept of not_found_handler but RouterEndpoint.fs does not.
Is this by design? What would the alternative be for not_found_handler for endpoint routing?

@dredgy
Copy link

dredgy commented Jan 21, 2022

This is explained here

https://saturnframework.org/explanations/endpoint-routing.html

Lack of not_found_handler in router and controller - as Endpoint Routing creates global table of routing having scoped not-found handlers is really tricky. Use built-in ways of handle 404 in ASP.NET (such as UseDeveloperExceptionPage)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants