Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First try the PHP version from .config.platform.php #132

Closed
wants to merge 1 commit into from

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 4, 2020

Fix #131

@EtienneM EtienneM requested a review from Soulou March 4, 2020 13:04
@EtienneM
Copy link
Member Author

EtienneM commented Mar 5, 2020

According to https://getcomposer.org/doc/06-config.md#platform we should actually use require.php to get the PHP version by default. I close this PR and update our documentation to reflect that.

@EtienneM EtienneM closed this Mar 5, 2020
@EtienneM EtienneM deleted the fix/131/php_version_config branch March 5, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP version] Default should be .config.platform.php
1 participant