Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom emoji reactions per MXC URL #217

Open
CrimsonFork opened this issue Nov 1, 2023 · 3 comments
Open

Custom emoji reactions per MXC URL #217

CrimsonFork opened this issue Nov 1, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@CrimsonFork
Copy link

SC web 1.11.30-sc.2, reactions just show the cleartext.
image

@SpiritCroc
Copy link
Member

It's not "broken" as the matrix spec doesn't tell you that these should be rendered if they are matrix urls yet. So until the appropriate MSC is merged which proposed that MXC urls can be sent "custom" reactions, just rendering any text that there is is actually the "expected" behaviour.
Rendering such reaction MXCs has actually been implemented in schildichat-desktop in https://github.com/SchildiChat/matrix-react-sdk/commits/image-reactions-sumner but hasn't found its way into a release yet.

@SpiritCroc SpiritCroc changed the title MXC URL in reaction brokey. Custom emoji reactions per MXC URL Nov 2, 2023
@SpiritCroc SpiritCroc added the enhancement New feature or request label Nov 2, 2023
@CrimsonFork
Copy link
Author

CrimsonFork commented Nov 2, 2023 via email

@TruncatedDinoSour
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants