Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coupling ratio #17

Open
AngleSideAngle opened this issue Jan 15, 2024 · 1 comment
Open

Add coupling ratio #17

AngleSideAngle opened this issue Jan 15, 2024 · 1 comment
Assignees

Comments

@AngleSideAngle
Copy link
Member

Because of the way swerve modules are designed, the rotation of a module's turn motor affects the rotation of a drive motor. This is negligible for control, but affects wheel odometry.

From ctre swerve code

For a typical swerve module, the azimuth turn motor also drives the wheel a nontrivial amount, which affects the accuracy of odometry and control. This ratio represents the number of rotations of the drive motor caused by a rotation of the azimuth.

For an implementation, see ctre swerve. This should be done in our SwerveModule class, since it applies to all max swerve modules.

@Yxhej
Copy link
Member

Yxhej commented Jan 17, 2024

Implemented in code, must figure out coupling ratio; keeping open as reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants