Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HorzMesh structure does not support non-periodic meshes #2

Open
andrewdnolan opened this issue Oct 2, 2024 · 0 comments · May be fixed by #3
Open

HorzMesh structure does not support non-periodic meshes #2

andrewdnolan opened this issue Oct 2, 2024 · 0 comments · May be fixed by #3
Assignees

Comments

@andrewdnolan
Copy link
Collaborator

Limitations Include:

  • When edgesOnVertex contains zeros (i.e. the vertex is along a culled boundary) an BoundsError is raised in the signIndexField! method, which tries to index arrays at 0. For example:

    ERROR: BoundsError: attempt to access 2×555 Matrix{Int32} at index [1, 0]
    Stacktrace:
     [1] getindex
       @ ./essentials.jl:14 [inlined]
     [2] getindex
       @ ./abstractarray.jl:1294 [inlined]
     [3] signIndexField!(dualMesh::MOKA.MPASMesh.DualCells{Int64, Vector{Float64}, Matrix{Int32}}, edges::MOKA.MPASMesh.Edges{Int64, Vector{Float64}, Vector{Int32}, Matrix{Float64}, Matrix{Int32}})
       @ MOKA.MPASMesh /global/u2/a/anolan/Moka.jl/src/infra/MPASMesh/HorzMesh.jl:323
     [4] ReadHorzMesh(meshPath::String; backend::KernelAbstractions.CPU)
       @ MOKA.MPASMesh /global/u2/a/anolan/Moka.jl/src/infra/MPASMesh/HorzMesh.jl:345
     [5] ReadHorzMesh(meshPath::String)
       @ MOKA.MPASMesh /global/u2/a/anolan/Moka.jl/src/infra/MPASMesh/HorzMesh.jl:334
     [6] top-level scope
       @ REPL[2]:1
    
  • Horizontal mesh structures do not yet have *Mask arrays (i.e. edgeMask) arrays, meaning horizontal boundary conditions (i.e. no slip) will not be correctly applied.

@andrewdnolan andrewdnolan self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant