Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get textoverlay demo working on linux #49

Open
thompson318 opened this issue Sep 9, 2022 · 5 comments
Open

Get textoverlay demo working on linux #49

thompson318 opened this issue Sep 9, 2022 · 5 comments
Labels
p2-medium Medium priority

Comments

@thompson318
Copy link
Collaborator

No description provided.

thompson318 added a commit that referenced this issue Sep 9, 2022
thompson318 added a commit that referenced this issue Sep 9, 2022
@thompson318
Copy link
Collaborator Author

py37 and vtk < 9.0 works ok.
There is no vtk<9.0 for py38 and greater and vtk9 just doesn't seem to work.

@mxochicale
Copy link
Contributor

mxochicale commented Nov 7, 2022

Hi @thompson318 ,
Which exact version of vtk you are using for py37 and vtk < 9.0 works ok.? and for which version of Ubuntu?

Perhap vtk/python versions are the source of the issues when running python vtkoverlay_app.py SciKit-Surgery/scikit-surgerytutorial01#31

@thompson318
Copy link
Collaborator Author

I've been messing around with trying to fix this in SciKit-Surgery/scikit-surgeryvtk#181. I've tried several versions. I'm currently thinking that we should move to vtk>9.0 and python > 3.9 for ubuntu.

@mxochicale mxochicale added the p2-medium Medium priority label Mar 9, 2023
mxochicale added a commit that referenced this issue Mar 22, 2023
mxochicale added a commit that referenced this issue Mar 23, 2023
@mxochicale
Copy link
Contributor

mxochicale commented Mar 23, 2023

Hi @thompson318

This issues has been partially solved in the coming merge of #53 as application is launching and visualising window with overlay text after adding self.vtk_overlay_window.Initialize() in common_overlay_app.py. However, the application don't close properly which will be followed in #54.

I think we keep this issue open and in the meantime, I think we can delete or archive stale branch https://github.com/SciKit-Surgery/scikit-surgeryutils/tree/49-getworkingonlinux.

Thanks

FYI.
Useful command for debugging and kill process for pytest -v -s tests/test_sksurgerytextoverlay.py

ps -ef | grep "test_*sksurgery*" | awk '{print $2}' | xargs kill

@mxochicale
Copy link
Contributor

Hi @thompson318

pytest -v -s tests/test_sksurgerytextoverlay.py is working but it does not close the app properly so I need to kill the process and I realised that the 49-getworkingonlinux branch has nothing to do with the latest changes of the lib, so I think it would be good to delete or archive stale branch https://github.com/SciKit-Surgery/scikit-surgeryutils/tree/49-getworkingonlinux ? Cheers, --Miguel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants