Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalarization in spatial code #1059

Open
isaacsas opened this issue Sep 20, 2024 · 1 comment
Open

scalarization in spatial code #1059

isaacsas opened this issue Sep 20, 2024 · 1 comment

Comments

@isaacsas
Copy link
Member

Since tests are now passing and I am not that familiar with the code, I haven't updated any spatial related codes to remove scalarization of parameters in #1052. This should probably be fixed up at some point though for consistency.

@isaacsas isaacsas mentioned this issue Sep 20, 2024
3 tasks
@TorkelE
Copy link
Member

TorkelE commented Sep 21, 2024

I'll have to have a think at whether this actually matters to the spatial code at all, since it just considers models after they are created. Either case I should add some tests to ensure that this is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants