remake problem tutorial lets user accidentally re-order parameters #388
Labels
bug
Something isn't working
Comments
|
Oh of course this is my minimal reproducible example of another project I'm working on, where I wanted to use the remake functionality rather than discretizing the problem again for each new set of parameters. The errors I got led me here. |
|
I guess the tutorial would be easier to apply for other purposes if the parameters in the remake call were also given as pairs, with newprob = remake(prob, p = [Dn => Dnval, Dp => Dpval])This way the parameters will be kept in order. |
|
Yes the tutorial should probably use the symbolic maps instead of assuming a data structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug 🐞
I ran the parameters code example but reversed the order of the parameters
DnandDp. Remaking the problem now causes the parameters to be switched in order, but this is hidden.Expected behavior
Giving the parameters in the same order in
discretizeand inremakeshould re-set the same parameters.Minimal Reproducible Example 👇
In the following code, the intention is that each parameter is incremented by a tiny amount, but the outcome is that they are switched (and incremented). The animation shows two quite different simulations, in spite of the intended increment being tiny.
Environment (please complete the following information):
using Pkg; Pkg.status()using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)versioninfo()The text was updated successfully, but these errors were encountered: