-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let default constructor initialize the GUIMetadata type #148
Comments
This seems misguided. Will this just be the same as the type name that would then be used for better lowering. @YingboMa should we just add that first? |
Should we always instantiate a component like @component function Resistor(; name, R)
@named oneport = OnePort()
@unpack v, i = oneport
pars = @parameters R = R
eqs = [
v ~ i * R,
]
extend(ODESystem(eqs, t, [], pars; name = name), oneport)
end ? |
I think so. And it would make a |
We then have to assume all the components are instantiated in the same world age, but I guess it's a fair assumption.
Since it would be a very simple type system within MTK, we would use some other encoding that's independent from Julia's so that we don't take unnecessary compile time hit. |
oh yes no val. But yeah, let's go this route. |
Something like this would be helpful e.g.
Maybe a symbol would fit better than a string?
The text was updated successfully, but these errors were encountered: