Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are Thermal[Conductor|Resistor] so different from their Convective* counterparts #172

Open
kakila opened this issue May 12, 2023 · 1 comment

Comments

@kakila
Copy link

kakila commented May 12, 2023

From a purely mathematical perspective both modes conduction and Convection are indistinguishable, both have the form h * dT.
Why is this not reflected in their implementations. For example:

  • Why does not the Thermal* element impose same flow on its ports/connectors?
  • Why is Conductive* not based on its Thermal* counterpart?
  • Why is the code of these elements so different?

In my view, Convective* (except for the heat flow conditions imposed) are just syntax sugar. Giving a semantic interface that allows the user to express the condition in which the exchange is between a solid and a fluid, but otherwise should not differ form the Conductive* (Thermal*) counterparts. Am I missing something?

@ven-k
Copy link
Member

ven-k commented May 29, 2023

The equations that are defined for ports are same. The Thermal* components extend the Elements1D which defines port_a, port_b; while Convective*'s port equations are in respective components.

Although the ports for both Thermal* and Convective* components are HeatPorts, the distinction is that former has HeatPort systems named as port_a and port_b, while latter has them as solid and fluid.


While here, I think I can define ConvectiveElements1D (which is similar to Elements1D, but has solid and fluid ports), and extend that. @baggepinnen what are your thoughts about this?

EDIT:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants