Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default values for support #199

Closed
wants to merge 1 commit into from
Closed

Conversation

baggepinnen
Copy link
Contributor

closes #198

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #199 (4c09f45) into main (ca8760b) will decrease coverage by 39.56%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #199       +/-   ##
===========================================
- Coverage   56.08%   16.52%   -39.56%     
===========================================
  Files          48       48               
  Lines        1578     1573        -5     
===========================================
- Hits          885      260      -625     
- Misses        693     1313      +620     
Impacted Files Coverage Δ
src/Mechanical/Rotational/sources.jl 0.00% <ø> (-71.43%) ⬇️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ven-k
Copy link
Member

ven-k commented Jul 20, 2023

RN, the default value of parameter use_support will be ignored by the component PartialElementaryOneFlangeAndSupport2.
I plan to fix DSL to handle it sometime soon; until then it should be explicitly passed as @named tor = Torque(; use_support = false)

I'll ping here, once that is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Torque can no longer be instantiated
2 participants