Skip to content

Add tests on FNO + DeepONet forward pass, gradients, and training #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisRackauckas opened this issue Feb 10, 2022 · 3 comments
Open

Comments

@ChrisRackauckas
Copy link
Member

The tests don't seem to cover the use and training of the operators, just a few properties. It would be good to get a few integration tests.

@ba2tripleO
Copy link

Do these tests need to run on gpu?

@pzimbrod
Copy link
Contributor

Yeah I think that makes sense at least for a subset of those, we also track that in a separate issue (#27).

Flux.jl also contains CUDA in the tests and since this package also exports layers and is based on Flux quite a bit, I would more or less stick to this.

@ChrisRackauckas
Copy link
Member Author

ChrisRackauckas commented Feb 16, 2022

I would start by making the tests on CPU though, then create equivalent tests on GPU. GPU will have a separate set of issues and it would be easier to catch/debug the CPU issues (usually correctness) first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants