Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache stripping to solution stripping #2393

Merged
merged 12 commits into from
Aug 22, 2024

Conversation

jClugstor
Copy link
Contributor

@jClugstor jClugstor commented Aug 19, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Related to SciML/SciMLBase.jl#629
I still need to add tests. I need to make a problem where the cache has jac_config and grad_config. And test that it strips the cache correctly.

This way I don't have to make dispatches for every individual cache that has jac_config or grad_config. I had to use eval(nameof(typeof(cache))) since typeof has the parametric type information, so I can't put all nothings into typeof of a concrete cache type.

@jClugstor
Copy link
Contributor Author

Actually, I don't need to use eval. These changes should work better.

@jClugstor
Copy link
Contributor Author

I believe this should be it for most of SciML/SciMLBase.jl#629

I think I'll need to add a test to SciMLBase making sure that strip_solution on a solution from an in place problem using an implicit method actually goes through and strips everything.

@jClugstor jClugstor marked this pull request as ready for review August 22, 2024 13:37
@ChrisRackauckas ChrisRackauckas merged commit 05f9229 into SciML:master Aug 22, 2024
51 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants