Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method overwritten #406

Open
baggepinnen opened this issue Mar 1, 2023 · 2 comments
Open

Method overwritten #406

baggepinnen opened this issue Mar 1, 2023 · 2 comments

Comments

@baggepinnen
Copy link
Contributor

The two methods
https://github.com/SciML/SciMLBase.jl/blob/c2bb35d917b0ca29595c97ea930882bd46534fa9/src/solutions/ode_solutions.jl#LL55-L62
are problematic, when calling sol(t, Val(1)) expecting that the first method will be called, the second method is actually called since it overwrites the two-argument version on the line above. t possibly needs a type restriction for the dispatch to work as intended

@baggepinnen
Copy link
Contributor Author

Hmm, the problem might have been that I used the value Val(1) instead of the type Val{1}, might be worth catching this error and either make it work, or provide a better error message

@ChrisRackauckas
Copy link
Member

That would cause it. Yes this API is quite old so it uses the old form pre-const prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants