Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix attributes aren't used for any optimizations #413

Open
CommanderTvis opened this issue Sep 15, 2021 · 0 comments
Open

Matrix attributes aren't used for any optimizations #413

CommanderTvis opened this issue Sep 15, 2021 · 0 comments
Labels
performance Performance optimization issue

Comments

@CommanderTvis
Copy link
Collaborator

CommanderTvis commented Sep 15, 2021

Constructs like public object IsZero : IsDiagonal have never been used for optimizations.

The existing code introduces several issues:

  1. It's difficult to reflect definition relationships. For example, diagonal matrices are always unitriangular, but the interfaces hierarchy does not reflect that.
  2. No existing logic uses attributes like IsZero to optimize operations, such as skipping determinant calculations when it’s obvious that the determinant will be zero. Other attributes are also unused.
  3. No way to validate if a matrix satisfies a desired attribute. For example, no function to check if all elements of a matrix are zero and then assign it the IsZero attribute accordingly.
@CommanderTvis CommanderTvis added the performance Performance optimization issue label Sep 26, 2021
@CommanderTvis CommanderTvis changed the title Optimize determinant computation by checking features Matrix attributes aren't used for any optimizations Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance optimization issue
Projects
None yet
Development

No branches or pull requests

1 participant