SPEC 0: drop py310 and support py313 #6195
Conversation
benchmarks/asv.conf.json
Outdated
| ], | ||
| "44fae030": [ | ||
| "ENV_PARENT={conf_dir}/.asv/env/nox310", | ||
| "PY_VER=3.10 nox --envdir={env_parent} --session=tests --install-only --no-error-on-external-run --verbose" |
There was a problem hiding this comment.
In this case I would prefer that we keep the old one too, as we occasionally have need to benchmark further back in history.
| @@ -37,16 +37,16 @@ | |||
| ], | |||
| "delegated_env_commands": { | |||
| "c8a663a0": [ | |||
| "ENV_PARENT={conf_dir}/.asv/env/nox313", | |||
There was a problem hiding this comment.
This is awkward - we don't know what the new commit hash will be once this is merged. I didn't think of that 🙄
There was a problem hiding this comment.
Discussed with @ESadek-MO: if you just provide one of the commit hashes that is on your branch, and then we'll merge this one with a merge-commit (not a squash).
There was a problem hiding this comment.
Like this bd6495c ?
There was a problem hiding this comment.
Almost, however there are now duplicate 3.13, which is what is causing the benchmark failure. The sequence should be 3.10, 3.11, 3.12, 3.13 - unlike other things we are not describing CI coverage, but support for benchmarking older commits if requested.
github-actions
bot
added
the
benchmark_this
|
Looks like python 3.13 is causing a lot of test failures. Most of these seem to be in cml files where I'm seeing |
|
Looks like this change might be the cause of the failing tests, python/cpython#107947 . |
|
hi folks, we are ready to roll out support for ESMValCore and Python 3.13 in ESMValGroup/ESMValCore#2566 - @bouweandela brought this issue to my attention, do we understand that |
The test failures are all caused by a change in XML character representation, which stops us comparing against known-good-outputs. This has made 5% of our tests 'blind' until we can work on a solution. But we have NO evidence of any Iris functionality breaking, and 95% of our tests still work and they show Iris functioning fine. Your own passing tests (ESMValGroup/ESMValCore#2566 (comment)) back this up even more. So the Iris 'project' cannot support Python 3.13 until we can get our CI working with 3.13; we have no immediate plans for finishing this work as we need space to finish some other things. But it looks like the Iris software supports 3.13 just fine already 👍. This happens with all new Python versions - our users have success with it before we even get a chance to test against it. |
wonderful, exactly the answer I was looking for, both wrt clarity and content, cheers, Martin! 🍺 |
🚀 Pull Request
Description
closes #6177