-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation strings are not translated #1902
Comments
Be sure that in the bottom of that file, after you have run the merge, you don't have empty strings. I would say this is the first guess without seeing your translation file. Can you share it? |
I don't think there are any empty strings at the bottom of the file. |
Peter,
try to remove the \n" " from the strings
Jean-Philippe
On Thu, Nov 15, 2018 at 10:43 AM Peter Dekker ***@***.***> wrote:
I don't think there are any empty strings at the bottom of the file.
Our translations file is here:
https://github.com/INL/taalradar/blob/master/translations/nl/LC_MESSAGES/messages.po
Thanks :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1902 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOHcq2kFrRYEiAGi3C7r3a2AP9vlImAJks5uvTc1gaJpZM4YeA-Z>
.
--
j:-P
|
@jeanphilippegoldman I tried to remove the \n" " (at the position of the space is actually a line break). I also fixed some errors using the POFileStatus and POFileChecker tools from gettext-lint. Still it does not work. |
Hi, I can see that your file is ok, but it's missing several strings. I've run the update on my local branch and this is the file that I get: At the end of the file you will find several strings that start with #. Just remove the hash, and translate them. Then recompile. This should do the trick. |
Thanks for your suggestion! I added the 4 empty translation strings from your file to my file, and translated them:
However, I still get the mixed translations in the login screen. Any ideas? |
I can report that the same problem occurs with the Portuguese translations from the repository. So probably it is not a problem in the translations file, but in the application code. |
The Portuguese translation is not up to date, so that's why it's not showing it. Checking the other. |
For the Spanish version it happens the same. The Not registered string is not translated it. |
So, after checking the translations file, I found that some strings were not translated. I've done the Spanish version now: Scifabric/pybossa-default-theme#174 Can you try it? It should show your site in Spanish, and the signin page in Spanish as well. If you compare the master vs the spanish-translation branch you will see how the master renders Spanglish, while the spanish-translation branch shows everything in Spanish. Thus, the issue is with the translation files not being fully translated. Can you try to update your translation files again? I've just followed the instructions in the docs, and they work really well. |
Hi, I followed your instructions, and it did not work yet. The generated messages.pot file is empty. I found out that this happens, because the paths in babel.cfg file are wrong. I changed babel.cfg to:
Now actually the right translation strings are generated in messages.pot and in the language-dependent messages.po file. EDIT: However, now I have a LOT of untranslated strings, and also a lot of strings I translated previously, which are not needed anymore. Could this be correct? |
I can also confirm that the spanish-translation branch gives a good translation, while the translation on the master branch gives a partial translation. |
Yes, the changes to babel.cfg are ok. That's a bug that we need to fix here. Regarding the partial translations: did you follow this https://docs.pybossa.com/translating/#step-1-extract-new-strings-which-should-be-translated |
Thanks! Yes, I followed the steps from the tutorial. After step 1, I get the following messages.pot: https://pastebin.com/MrTtYtSv |
Then, go for step 2. It should update with existing translations, if any. |
After step 2, I get this |
Closing it as this has been not updated in a long time. |
I have created a Dutch translation for PYBOSSA. However, when I test it, I see that a part of the translation strings is not used. This results in mixes of translated and untranslated phrases in the interface.
Eg. I translated this string in the login window:
#: themes/default/templates/account/signin.html:7 msgid "" "below you are agreeing to\n" " the" msgstr "" "hieronder verklaart u dat u akkoord gaat\n" "met de"
It looks like this in the interface:
https://screenshots.firefox.com/z1EDwxIquekUKBpf/localhost
There are more places where I saw this.
Thanks in advance for looking into this!
The text was updated successfully, but these errors were encountered: