Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor _commonFuzzerAssumptions method in the FlexVotingClient tests #74

Open
3 tasks
apbendi opened this issue Nov 15, 2024 · 0 comments
Open
3 tasks
Assignees

Comments

@apbendi
Copy link
Member

apbendi commented Nov 15, 2024

The _commonFuzzerAssumptions method should be updated in a few ways for clarity, convention, and test speed:

  • Use bound rather than assume for the support type value, cast it to the enum type, and return it from the method (as a tuple along with vote weight)
  • Rename _address to _account (nit)
  • Rename the method to something more active, maybe _assumeSafeAccountAndBoundVote or similar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants