From 7d4fcc70ccf65c76e6452c88a7b2c9422a80b635 Mon Sep 17 00:00:00 2001 From: Dave Patrick Caberto Date: Mon, 22 Jul 2024 19:05:23 +0800 Subject: [PATCH] misc: drop experimental vaapi profiles They will soon be deprecated. --- README.md | 16 +++++++--------- data/resources/profiles.yml | 26 -------------------------- src/profile.rs | 2 +- 3 files changed, 8 insertions(+), 36 deletions(-) diff --git a/README.md b/README.md index 2d895193..3189f4be 100644 --- a/README.md +++ b/README.md @@ -64,14 +64,12 @@ performance degradation. However, they can be enabled manually by running Kooha with `KOOHA_EXPERIMENTAL` env var set to `all` (e.g., `KOOHA_EXPERIMENTAL=all flatpak run io.github.seadve.Kooha`), or individually, by setting `KOOHA_EXPERIMENTAL` to the following keys (e.g., `KOOHA_EXPERIMENTAL=experimental-formats,window-recording`): -| Feature | Description | Issues | -| ------------------------ | ------------------------------------------------------------------------ | ------------------------- | -| `all` | Enables all experimental features | - | -| `experimental-formats` | Enables other codecs (e.g., hardware-accelerate encoders*, VP9, and AV1) | Stability | -| `multiple-video-sources` | Enables recording multiple monitor or windows | Stability and performance | -| `window-recording` | Enables recording a specific window | Flickering | - -\* Requires `GST_VAAPI_ALL_DRIVERS` env var to be set to `1` and `gstreamer-vaapi` to be installed. +| Feature | Description | Issues | +| ------------------------ | ----------------------------------------------------------------------- | ------------------------- | +| `all` | Enables all experimental features | - | +| `experimental-formats` | Enables other codecs (e.g., hardware-accelerate encoders, VP9, and AV1) | Stability | +| `multiple-video-sources` | Enables recording multiple monitor or windows | Stability and performance | +| `window-recording` | Enables recording a specific window | Flickering | ## 📋 Runtime Requirements @@ -106,7 +104,7 @@ The following packages are required to build Kooha: * gstreamer * gstreamer-plugins-base * gstreamer-plugins-ugly (for MP4) -* gstreamer-vaapi (for hardware acceleration) +* gstreamer-plugins-bad (for VA encoders) * glib2 * gtk4 * libadwaita diff --git a/data/resources/profiles.yml b/data/resources/profiles.yml index 76a03c09..3a8a37d3 100644 --- a/data/resources/profiles.yml +++ b/data/resources/profiles.yml @@ -99,29 +99,3 @@ experimental: queue ! mpegaudioparse muxer: mp4mux fragment-duration=500 fragment-mode=first-moov-then-finalise - - - id: vaapi-vp8 - name: WebM VAAPI VP8 - extension: webm - videoenc: > - glupload ! glcolorconvert ! gldownload ! - vaapivp8enc ! - queue - audioenc: > - audioconvert ! - opusenc ! - queue - muxer: webmmux - - - id: vaapi-vp9 - name: WebM VAAPI VP9 - extension: webm - videoenc: > - glupload ! glcolorconvert ! gldownload ! - vaapivp9enc ! - queue - audioenc: > - audioconvert ! - opusenc ! - queue - muxer: webmmux diff --git a/src/profile.rs b/src/profile.rs index 0f4f4691..da2a243f 100644 --- a/src/profile.rs +++ b/src/profile.rs @@ -290,7 +290,7 @@ mod tests { for profile in Profile::all().unwrap() { // These profiles are not supported by the CI runner. - if matches!(profile.id(), "vaapi-vp8" | "vaapi-vp9" | "va-h264") { + if matches!(profile.id(), "va-h264") { continue; }