Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for YAML frontmatter from (https://github.com/tejasvi/markless/issues/16) #13

Open
Sean10 opened this issue Oct 27, 2021 · 2 comments
Open

Support for YAML frontmatter from (https://github.com/tejasvi/markless/issues/16) #13

Sean10 opened this issue Oct 27, 2021 · 2 comments
Labels
question Further information is requested

Comments

@Sean10
Copy link
Owner

Sean10 commented Oct 27, 2021

No description provided.

@Sean10 Sean10 closed this as completed in 4454335 Oct 27, 2021
@Sean10 Sean10 changed the title Support for YAML frontmatter from [Support for YAML frontmatter · Issue \#16 · tejasvi/markless](https://github.com/tejasvi/markless/issues/16) Support for YAML frontmatter from (https://github.com/tejasvi/markless/issues/16) Oct 27, 2021
@Sean10 Sean10 mentioned this issue Oct 27, 2021
Open
@srid
Copy link

srid commented Oct 27, 2021

It fixes it more or less, though there is a horizontal gray line at the topi:

image

I'd think the parser should ignore both the --- lines (above and below the frontmatter), not just the ending line.

@Sean10
Copy link
Owner Author

Sean10 commented Oct 27, 2021

Now i have questions about why remark mark the ending --- line is part of the heading node, so i'm not sure it should be removed or not is correspond with commonmark.

It will take time.

like this remark test demo.
remark/heading-setext-with-initial-spacing.text at 25c7a324403afc68cdf54ab85d566516228cc639 · remarkjs/remark
remark/heading-setext-with-initial-spacing.json at 25c7a324403afc68cdf54ab85d566516228cc639 · remarkjs/remark

@Sean10 Sean10 reopened this Oct 27, 2021
@Sean10 Sean10 added the question Further information is requested label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srid @Sean10